The following shows the diffstat and patchsets between
cc2034a..ed2067b^
----------------------------------------------------------------
commit ed2067b3be95dd71fcae9bef8fa8dfd002254871
Author: Thomas Adam <[email protected]>
Date: Sun Sep 21 22:30:07 2014 +0100
FScreenGetScrRect: Remove m == NULL check (GCC fix)
Because FScreenGetScrRect() initialises values passed in for coordinates,
don't test to see if the given monitor is NULL (which would have
resulted in the premature exit of this function, potentially leaving the
values unassigned).
We always guarantee finding a given monitor, and hence can set these values
correctly. The original check was bogus, and caused GCC to rightly complain
about potential uninitialised values (-Werror=maybe-uninitialized).
---
libs/FScreen.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libs/FScreen.c b/libs/FScreen.c
index f23a0c6..c0e7dbe 100644
--- a/libs/FScreen.c
+++ b/libs/FScreen.c
@@ -399,8 +399,6 @@ Bool FScreenGetScrRect(fscreen_scr_arg *arg, fscreen_scr_t
screen,
int *x, int *y, int *w, int *h)
{
struct monitor *m = FindScreen(arg, screen);
- if (m == NULL)
- return (True);
if (x)
*x = m->coord.x;
----------------------------------------------------------------
Diffstat:
----------------------------------------------------------------
libs/FScreen.c | 2 --
1 file changed, 2 deletions(-)
----------------------------------------------------------------
