On Tue, Dec 30, 2014 at 03:24:32PM +0100, Dominik Vogt wrote:
> I've spent a lot of time to remove the include directives from the
> library header files in the dv/new-parser branch. Such
> dependencies make it very difficult to include the headers from
> other places. My policy has always been (and will always be) to
> not include *anything* in a header file (except if the header file
> was explicitly written to include other headers and does nothing
> else).
Right, so shift as much into the .c file as necessary and not have them
extraneously added to the .h file? That makes sense; I hadn't
appreciated that, and I'll fix that.
The include is only there for the benefit of the definition of ewmhInfo.
> > typedef union
> > {
> > @@ -41,6 +45,9 @@ struct monitor {
> > */
> > DesktopsInfo *Desktops;
> >
> > + /* Information about EWMH */
> > + ewmhInfo ewmhc;
>
> Yuck! Please don't include typed from the core in the library.
It's not the only place where this is done, although note that the
notion of "library" in this case is rather misleading---the concept
could easily be done away with. However, that's not the point, I
appreciate that.
I think what I'll do in this case is put a copy of the struct into this,
and remove the include, that'll solve a few things.
-- Thomas Adam
--
"Deep in my heart I wish I was wrong. But deep in my heart I know I am
not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.)
