On Wed, Dec 28, 2016 at 3:16 AM, Dominik Vogt <dominik.v...@gmx.de> wrote: > On Tue, Dec 27, 2016 at 05:34:08PM -0700, Jaimos Skriletz wrote: >> On Tue, Dec 27, 2016 at 5:28 PM, Jaimos Skriletz >> <jaimosskril...@gmail.com> wrote: >> > On Tue, Dec 27, 2016 at 5:15 PM, Dominik Vogt <dominik.v...@gmx.de> wrote: >> >> On Tue, Dec 27, 2016 at 05:04:40PM -0700, Jaimos Skriletz wrote: >> >>> On Tue, Dec 27, 2016 at 4:52 PM, Jaimos Skriletz >> >>> <jaimosskril...@gmail.com> wrote: >> >>> > On Tue, Dec 27, 2016 at 3:44 PM, Dominik Vogt <dominik.v...@gmx.de> >> >>> > wrote: >> >>> >> On Mon, Dec 26, 2016 at 01:17:05PM -0700, Jaimos Skriletz wrote: >> >>> >>> Hello, >> >>> >>> >> >>> >>> This was reported by a Debian user. Please retain the CC to >> >>> >>> 849355-forwar...@bugs.debian.org in your response, so that >> >>> >>> the Debian BTS has a record. >> >>> >>> >> >>> >>> In short when running FvwmIconMan, fvwm prints warnings to stderr >> >>> >>> when >> >>> >>> opening and closing windows. I too have had this issue in 2.6.7 (and >> >>> >>> previous versions) so I can also say it affects my Debian system. >> >>> >> >> >>> >> >> >>> >> I don't get any such messages with or without FvwmIconMan. Can >> >>> >> you give detailed instructions pelase? >> >>> >> >> >>> > >> >>> > Using Fvwm 2.6.7 Debian package, doubt it is any of the debian >> >>> > patches, but I will compile a version without patches and test. >> >>> > >> >>> >> >>> Tested with a fresh compile of Fvwm 2.6.7 without any debian patches, >> >>> same issue. >> >>> >> >>> > >> Further testing, if I set the ManagerGeometry to something like 5x3 so >> FvwmIconMan doesn't resize itself, I no longer get the warning. It is >> only with the default like 0x1, causing the window to grow/shrink I >> get the warning. > > Could be reproduced with a standalone FvwmIconMan (instead of the > one inside FvwmButtons). >
Good, I thought I said it had to be stand alone in my description, glad you were able to track it down. >> Wild guess, could it be some timing issue during the resizing of the >> window when adding/removing a button cause the window's current size >> to become invalid as per the warning? > > Roughly, yes. FvwmIconMan sets the minimum and maximum width and > height size hints to the new geometry it wants, then requests the > new size. When fvwm reads the new hints, the current geometry of > the manager window becomes obviously invalid until the window is > also resized. That's what triggers the warning. > > So, to fix this: > > 1. Remove the size restrictions, then resize, then set the new > size restrictions. Theoretically the winodw might be resized > by the user in between, but that's highly unlikely. > > 2. Also print the size hints that trigger this warning in a second > message. > > Fixed on the (new) fvwm2-stable branch; patch for the development > branches will follow one I've figured out how to deal with the > two repositories. > Thanks, though I think there is some confusion about what is the 'stable' branch and 'development' branch(s) right now. Anyways I'll send another email about this. jaimos
