> > Ideally it should be done differently by specifying Greyed flag, not by > > some ascii character in front of the string. I would like if we stop this > > hacking that breaks things that are automated. I.e. all automatic menu > > generation scripts should include the same escape engine that fvwm itself > > uses to parse item strings. This is not good. > > > > I like this patch, but can we delay it until we solve the problem of > > specifying more than one action for the menu item? This will make it > > possible to specify "Grayed" option just like "CommandOnMouse 2" option.
I like this option better as well. Tell you what, I'll start looking into this and see what I can come up with. Well, after we have some discussion about it. =D > How about dumping that whole screwed up method to specify options > for individual menu items and doing it from scratch? E.g. > > NewAddToMenu menu_name item_name [(item_options)] ItemAction > NewAddToMenu menu_name (menu_options) > > and > > + item_name [(item_options)] ItemAction > + (menu_options) > > The item_options and menu_options are enclosed in parentheses and > can be omitted. > > Menu options: > DynamicPopupAction > DynamicPopdownAction > MissingSubmenuFunc > SidePicture > SideColor > (did I forget anything?) Couldn't we just do this in MenuStyle or something along those lines? IE, if it has to do with the menu as a whole, do it with MenuStyle. If it has to do with Items, do it on a per-item basis? > Item options: > Greyed > Hotkey > Picture What is the "Picture" one? Not that menu code really causes a lot of slowdown, but if nothing else, having the Hotkey specified here will stop every line from having to be parsed every time... which I like. I might have some other ideas of things to stick here as well. > The mini icons should stay parts of the labels because they are > formatted like the text. I'd definitely agree with this, simply because no one can be sure exactly where the user would want the pixmap to appear. Except.. that kinda kills my "don't parse every line" thing. lol I'm not sure there's really another option for pixmaps other than limiting options and having a: Pixmap <filename> PixmapAlignment left | right item style set. =/ > The proposed syntax is almost completely compatible with the old. > Only items that have a name enclosed in parentheses but no action > or items that have an action beginning with a left parenthesis > are interpreted differently. I can't hink of any reason why > someone would want that. This is true, but at least they would get a complaint about the line and go edit it (at least I assume). The only option I can think of to insure backwards compatibility would be: AddToMenu menu_name item_name ItemAction AddToItem item_options + item_name ItemAction * item_options (or ++ or : or whatever) Except for the fact that old menu item options wouldn't be parsed anymore and would just show up in the menu item label, this would be 100% backwards compatible I think. I kinda like this route better so as not to ultra-clutter the AddToMenu lines. Daniel -- /\\\----------------------------------------------------------------------///\ \ \\\ Daniel Henninger http://www.vorpalcloud.org/ /// / \_\\\ North Carolina State University - Systems Programmer ///_/ \\\ Information Technology <IT> /// """--------------------------------------------------------------""" -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
