On 16 Mar 2002 15:49:20 +0100, Dominik Vogt wrote:
> 
> On Fri, Mar 15, 2002 at 01:15:56PM -0500, Daniel Henninger wrote:
> [snip]
> > Hrm.  Yeah, that would get ugly real quick.  Would doing something like
> > what follows be interesting?
> > 
> > NewAddToMenu "AppMenu"
> > +   Style           SidePixmap "ninja.xpm"
> > +   Style           SideColor gray
> > +   Item            "Application Menu" Title
> 
> > +   Item            "" Nop
> 
> Better:
> 
>   +     Item            Separator
> 
> > +   Item            "Corporate Time" Exec /usr/local/bin/ctime
> > +   Property        Greyed
> > +   Property        Hotkey T
> > 
> > And maybe allow for S for style, I for item, P for property, etc?
> 
> That matches the method for defining functions nicely.  I like the
> idea, but see my comments below.
> 
> [snip]
> 
> > > >  I'm not sure there's really
> > > > another option for pixmaps other than limiting options and having a:
> > > > Pixmap <filename>
> > > > PixmapAlignment left | right
> > > > item style set.  =/
> > >
> > > The alignment can be defined with the MenuStyle.
> > 
> > Ah, via the ItemFormat option?
> 
> Yup.
> 
> > Now that I've read over the pixmap inclusion thing, I think I'd prefer to
> > take that out of the actual menu entry as well and put it up as a:
> > +   Property        Pixmap <filename>
> 
> Hm.  Shouldn't there be a way to define items is a single line (?)
> On the other hand, if we ever add separate actions to the mouse
> buttons for each menu item, it's going to be very ugly to have all
> commands on a single line.  How about this (the indentation is
> chosen for readability only):
> 
>   + Style            SidePixmap  "ninja.xpm"
>   + Style            SideColor   gray
>   + Item             "Application Menu" Title
>   + Separator
>   + Item             "Corporate Time"
>   +   Action         (mouse 1) Exec /usr/local/bin/ctime
>   +   Action         (mouse 2) Exec foobar
>   +   Property       Greyed
>   +   Property       Hotkey T

Do we really need to mix everything into one command?

I think we need:

  AddToMenu - don't touch it, for backward compatibility only
  AddMenuStyle menu_name - a new command, allows "+"
  AddMenuItems menu_name - a new command, allows "+"

But I prefer to think about a new design in depth before saying anything
more. There are so many small issues to solve.

Regards,
Mikhael.
--
Visit the official FVWM web page at <URL:http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]

Reply via email to