On 16 Apr 2002 15:13:30 +0100, Tim Phipps wrote: > > Is it time to move the colorset handling from FvwmTheme to fvwm?
Actually moving the FvwmTheme code and replacing it with a pass-through module was on my todo list, near the top. But if you may do it, fine. I didn't plan to break any existing configs at this stage though. > What I'm thinking of is: > > *) copy most of modules/FvwmTheme/FvwmTheme.c to fvwm/colorset.c > *) new command Colorset that calls fvwm/colorset.c > *) new command ReadWriteColors to replace *FvwmThemeReadWriteColors > *) a very simple replacement for FvwmTheme that just turns config lines > into Colorset commands and prints a warning. We should also add DeleteColorset somewhen to emulate DestroyModuleConfig. > *) strip out every color type command from fvwm and all the modules > > Advantages: > *) Much less code in the modules for color handling so less bugs > *) Smaller man pages for the modules > *) Initializing colorset 0 to black/white with a stipled pixmap > background will enable monochrome monitors to have a 3d look and we > can lose all the "if (Pdepth < 2)" code > *) by default fvwm and the modules won't alloc any color cells > > Disadvantages: > *) lots of configs would break but the result would just be that > everything uses colorset 0 so it would just look a bit boring. I don't know. I think this is 2 independent tasks. FvwmTheme may be obsoleted now without anyone noticing, but maybe removing non colorset color functionality may be done after 2.6.x, i.e. in 2.9.x? The main problem here is still TitleStyle, ButtonStyle, BorderStyle. I am not sure about the last 2 advantages, maybe I don't understand it, but monochrome monitors don't really need to dictate the (ugly) default. Regards, Mikhael. -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
