On Wed, Apr 17, 2002 at 12:00:49PM +0100, Tim Phipps wrote: > [EMAIL PROTECTED] wrote: > > >On 16 Apr 2002 15:13:30 +0100, Tim Phipps wrote: > > > >> Is it time to move the colorset handling from FvwmTheme to fvwm? > >> > >Actually moving the FvwmTheme code and replacing it with a pass-through > >module was on my todo list, near the top. But if you may do it, fine. > >I didn't plan to break any existing configs at this stage though. > > > OK, I'll do a patch that moves FvwmTheme into fvwm, I'll leave removing > stuff for later. > > >We should also add DeleteColorset somewhen to emulate DestroyModuleConfig. > > > There are problems with deleting colorsets that modules may be using > since they share the resources rather than copy them. Would it be > acceptable for DeleteColorset to reset the colorset to a simple default > rather than really delete it?
What else could be done? The few bytes of wasted memory for the structure are irrelevant if the pixmaps are freed. > >>*) strip out every color type command from fvwm and all the modules > >> > >>Advantages: > >>*) Much less code in the modules for color handling so less bugs > >>*) Smaller man pages for the modules > >>*) Initializing colorset 0 to black/white with a stipled pixmap > >> background will enable monochrome monitors to have a 3d look and we > >> can lose all the "if (Pdepth < 2)" code > >>*) by default fvwm and the modules won't alloc any color cells > >> > >I don't know. I think this is 2 independent tasks. > > > >FvwmTheme may be obsoleted now without anyone noticing, but maybe removing > >non colorset color functionality may be done after 2.6.x, i.e. in 2.9.x? > > > OK, I just thought that now might be a good time since we've just > changed fvwm2 to fvwm. I'd rather leave the big changes for 3.0. Maybe we should make the 2.6 release in about half a year (I mean the release date, not the feature freeze). > >I am not sure about the last 2 advantages, maybe I don't understand it, > >but monochrome monitors don't really need to dictate the (ugly) default. > > > There are lots of instances of code that only get used on monochrome > monitors, do a grep for Pdepth and count the number of "if (Pdepth < > 2)"s. If fvwm's default colorset worked well on monochrome monitors we > could remove all this code. Yes, that would be a big step in the right direction. Bye Dominik ^_^ ^_^ -- Dominik Vogt, email: [EMAIL PROTECTED] LifeBits Aktiengesellschaft, Albrechtstr. 9, D-72072 Tuebingen fon: ++49 (0) 7071/7965-0, fax: ++49 (0) 7071/7965-20 -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
