On Mon, Apr 22, 2002 at 02:22:37PM +0000, Mikhael Goikhman wrote: > On 20 Apr 2002 16:08:38 +0000, Mikhael Goikhman wrote: > > > > But I think you may reproduce this error > > > > [FVWM][FvwmErrorHandler]: <<ERROR>> *** internal error *** > > [FVWM][FvwmErrorHandler]: <<ERROR>> Request 56, Error 13, EventType: 0 > > > > using this minimal config (fvwm -f colorset-bug): > > > > ModuleSynchronous FvwmTheme > > *FvwmTheme: Colorset 1 fg black, bg gray50, VGradient 30 gray40 gray60 > > > > You may switch these lines - the same result. > > > > Now, if you remove a comma after "black" or remove fg and bg parts > > altogether you get core dump. I think this is because image is NULL in > > line 586 of colorset.c. > > After the latest Olivier commits, these problems are solved. > Gradients now fully work with fvwm-themes. > > I would like to know what was the problem and when it was introduced? >
Form the ChangeLog: * fvwm/colorset.c (parse_colorset): Use the Scr.NoFocusWin as main window in the place of the Scr.SizeWindow, this fix a lot of X errors in my machine. I do not think the use of the SizeWindow was correct, it causes problem when you create the static gc in parse_colorset. If you take a look at the code the SizeWindow is created after the config file is read. Also, since a long times it is the Scr.NoFocusWin which is used for loading FvwmPicture, so I used the Scr.NoFocusWin (which is created as soon as possible with the good parameters) and I saw no more FvwmErrorHandler error ... so I think the change is good :o) Olivier -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
