Hi Dominik,
Here is a new patch to move the REDRAW_BG #define to the manager dirty bits
instead of the button dirty bits. I grouped it with the wrong defines. This is
for 2.5
Cheers
Dave
Dominik Vogt wrote:
> On Wed, May 22, 2002 at 11:28:39PM -0500, Dave Trollope wrote:
> > Hi,
> >
> > I have for quite sometime been wondering why on my system the
> > FvwmIconMan background was getting left corrupted when another window
> > was put on top of it, and then removed. Here is a patch.
> >
> > The problem was that between 1.4.5 and now, an if() in draw_manager()
> > was removed and the clear_empty_region() was (I think) moved. However it
> > was moved to an if() with different conditions - it used to be called
> > because numWindows > 0 (almost always) but this was no longer true.
> >
> > So, when an Expose event was received, the draw_managers was called and
> > the clear_empty_region() was never called. So I added to the dirty_flags
> > a REDRAW_BG flag, and set it from within man_exposed. This triggers the
> > redrawing of the background for the expose events.
> >
> > Please take a look at the patch and include it in the next build.
>
> Hm, wasn't that already fixed? For which release is that patch?
> 2.4.x or 2.5.x?
>
> Bye
>
> Dominik ^_^ ^_^
>
> --
> Dominik Vogt, email: [EMAIL PROTECTED]
> LifeBits Aktiengesellschaft, Albrechtstr. 9, D-72072 Tuebingen
> fon: ++49 (0) 7071/7965-0, fax: ++49 (0) 7071/7965-20
>
> --
> Visit the official FVWM web page at <URL:http://www.fvwm.org/>.
> To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
> body of a message to [EMAIL PROTECTED]
> To report problems, send mail to [EMAIL PROTECTED]
Index: ChangeLog
===================================================================
RCS file: /home/cvs/fvwm/fvwm/ChangeLog,v
retrieving revision 1.1813
diff -u -u -r1.1813 ChangeLog
--- ChangeLog 2002/05/27 21:27:14 1.1813
+++ ChangeLog 2002/05/29 01:56:01
@@ -1,3 +1,9 @@
+2002-05-27 Dave Trollope <[EMAIL PROTECTED]>
+
+ * Modules/FvwmIconMan/xmanager.c:
+ Changed the REDRAW_BG from 128 to 16 and moved to manager dirty bits
+ group.
+
2002-05-27 olicha <[EMAIL PROTECTED]>
* acinclude.m4:
Index: modules/FvwmIconMan/xmanager.c
===================================================================
RCS file: /home/cvs/fvwm/fvwm/modules/FvwmIconMan/xmanager.c,v
retrieving revision 1.65
diff -u -u -r1.65 xmanager.c
--- modules/FvwmIconMan/xmanager.c 2002/05/27 12:02:49 1.65
+++ modules/FvwmIconMan/xmanager.c 2002/05/29 01:46:55
@@ -35,13 +35,13 @@
#define STRING_CHANGED 16
#define REDRAW_BUTTON 32
#define GEOMETRY_CHANGED 64
-#define REDRAW_BG 128
/* manager dirty bits: */
/* GEOMETRY_CHANGED 64 same as with button */
#define MAPPING_CHANGED 2
#define SHAPE_CHANGED 4
#define REDRAW_MANAGER 8
+#define REDRAW_BG 16
/* ButtonArray dirty bits: */
#define NUM_BUTTONS_CHANGED 1
