Hi Dominik,

Dominik Vogt wrote:

> On Tue, May 28, 2002 at 09:28:10PM -0500, Dave Trollope wrote:
> > Hi Dominik,
> >
> > Here is a new patch to move the REDRAW_BG #define to the manager dirty bits
> > instead of the button dirty bits. I grouped it with the wrong defines. This 
> > is
> > for 2.5
>
> Thanks, I'll apply it.  Could you please make the same patch for
> 2.4.7?

Funny you say that, I downloaded the 2.4 branch to do just that, but I found the
clear_empty_region() is still called based on num_windows:

void draw_manager (WinManager *man)
{
  int i, force_draw = 0, update_geometry = 0, redraw_all = 0;
  int shape_changed = 0;
[snip]
  if (redraw_all || (man->buttons.dirty_flags & NUM_WINDOWS_CHANGED)) {
    ConsoleDebug (X11, "\tresizing manager\n");
    resize_manager (man, redraw_all);
    update_geometry = 1;
    force_draw = 1;
  }
  if (force_draw || man->buttons.num_windows != 0)
    clear_empty_region (man);
...

This is in pretty much all cases. It was this last if that was removed in 2.5.x 
so I
don't think this fix is necessary in 2.4.x


> > Index: ChangeLog
> > ===================================================================
> > RCS file: /home/cvs/fvwm/fvwm/ChangeLog,v
>
> BTW, that's the wrong ChangeLog file.  Changes in the modules
> directory are logged in fvwm/modules/ChangeLog.
>

Sorry, will do it there next time.
Thanks!
Dave


--
Visit the official FVWM web page at <URL:http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]

Reply via email to