On Wed, Jul 10, 2002 at 10:02:19PM +0000, Mikhael Goikhman wrote:
> > We should continue to support direct gradient drawing
> > since they look a lot better this way (less blocky).
>
> Hmm, I didn't know they use 2 different methods.

I couldn't remember either until I debugged the problem Remko
reported yesterday.

> Maybe solid color blocks in colorset gradients should be placed
> depending on the gradient type?

They are not really placed


> Placing them in a rectangular grid is only good for {H,V,S}Gradient.

Not always.  In a window title, B and D gradients would look
almost exactly like HGradient if the lines were always drawn at
45 degrees.  In rectangles with a more even aspect ratio (menus
for example), the old way looks a bit better.

On Thu, Jul 11, 2002 at 08:18:18AM +0200, Olivier Chapuis wrote:
> > Olivier:  I guess you added that XClearArea() call.  Do you know
> > of any other places in the menu code where you added similar
> > calls?  We should continue to support direct gradient drawing
> > since they look a lot better this way (less blocky).
> >
> 
> I do not think that there is an other place in the menu code
> where I added such clearing. I was not award that B/DGradient
> is drawn on the foreground. 
> 
> But what about redrawing the relevant part of the gradient
> in this case: in the place of the XClearArea put (around
> line 404 of menuitems.c (+ do paint_menu_gradient_background
> global (menus.c + menus.h) and pass mr in some way to
> menuitem_paint).

[snip]

I now remember why we are drawing in the foreground.  It's not
because of the looks but because a potentially huge pixmap has to
be kept in XServer memory.  I'm unwilling to add a lot of
additional code just for the benefit of the old B/DGradient
implementation.  Should we just document that a few features do
not work with the old gradient code?

Bye

Dominik ^_^  ^_^

 --
Dominik Vogt, mail: [EMAIL PROTECTED], phone: 0721/91374-382
Schlund + Partner AG, Erbprinzenstr. 4-12, D-76133 Karlsruhe
--
Visit the official FVWM web page at <URL:http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]

Reply via email to