On Sat, Feb 04, 2006 at 08:51:33PM +0000, David Maciver wrote: > On Sat, 21 Jan 2006 04:17:43 +0000, David Maciver wrote: > > Hello, > > > > I've written a patch that lets you configure the menu title and colorset > > separately from the rest of the menu. > > > > I've added menustyle options HilightTitle, TitleColorset and TitleFont. > > > > Here is an example of what it looks like: > > http://metawire.org/~frogb/menu2.png > > > > Patch against CVS: > > http://metawire.org/~frogb/menutitle.patch > > > Could this be included in fvwm? This sort of configuration seems quite > popular in other window managers. It was originally posted on the fvwm > forum[1] where people seem to want it. It seems to work ok for me but is > there anything that should be changed/fixed in the code, or any reason > this cannot be accepted? > > [1] http://fvwm.lair.be/viewtopic.php?t=1141
I have applied the patch with some changes and bugfixes:
* The text of the menuitem is always drawn in the given colour
set (this required a bugfix in the text drawing library).
* Renamed the HilightTitle option to HilightTitleBack. It just
controls whether the background of the title is hilighted.
* Corrected the calculations of the area to hilight. Now it
always hilights the whole title, not just the area with the
relief on menu items (which can be smaller if the ItemFormat
style is used).
For future patches, please include
* NEWS entries for new features and bugfixes.
* Documentation in the man page (fvwm.1.in).
* ChangeLog entries including the names of all files and
functions changed and a short comment.
* Optionally an entry for the AUTHORS file.
This cuts down the time I spend to handle patches a lot because if
you don't write it, I have to do it (which is much more work
because I have to learn everything from the code first).
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt, [EMAIL PROTECTED]
signature.asc
Description: Digital signature
