On Wed, Nov 20, 2002 at 11:42:43AM +0100, Bart Lateur wrote: > On Wed, 20 Nov 2002 04:10:02 -0600, Steven Lembark wrote: > > >sub commify > >{ > > my ( $max, $sep, $end ) = ( shift, shift, shift ); > ... > >} > > Wow! Hold it! Am I the only one who finds this absurd? More than one > shift on the same array in one single expressing, sounds like bad style > to me. Comments?
Why is that bad style? Many times when people say it's bad style, it's just a case of "beauty is in the eye of the beholder". However, sometimes a style is bad because it's error-prone, confusing, similar to common idiom but doing something else, or inefficient. But I don't think any of them applies to this particular example. Bart, can you explain why this is bad style? Or is it just your personal preference? Abigail