On Tue, Apr 20, 2010 at 9:31 AM, Iustin Pop <[email protected]> wrote: > On Mon, Apr 19, 2010 at 04:54:37PM +0100, Guido Trotter wrote: >> Currently some hypervisors (namely kvm) need to do some cleanup after >> making sure an instance is stopped. With the moving of the retry cycle >> in backend those cleanups were never done. In order to solve this we add >> a new optional hypervisor function, CleanupInstance, which gets called >> at the end of the shutdown procedure, and which interested hypervisors >> can implement to be sure not to miss cleanup operations. >> >> Signed-off-by: Guido Trotter <[email protected]> > > NAK. > > See my patch from yesterday which fixes this by removing the retry cycle > from backend. > > The rationale for not adding a separate cleanup step (which I thought > about) is that: > > - you cannot know just from instance list whether to run or not the > Cleanup > - the existence of a new state (shutdown but not cleaned up) should be > reflected all across to the master and command line tools, and we > don't want that > - it is cleaner to just make sure StopInstance does all the neeed > cleanup, rather than introduce a new step > > Let's discuss! >
Ok, that solution works well for me! :) Thanks, Guido -- Subscription settings: http://groups.google.com/group/ganeti-devel/subscribe?hl=en
