On Tue, Apr 20, 2010 at 10:51:44AM +0100, Guido Trotter wrote: > On Tue, Apr 20, 2010 at 10:50 AM, Iustin Pop <[email protected]> wrote: > > > > I just realized: most, if not all, hypervisors have the following > > things: > > > > - is instance running? > > - cleanly stop instance > > - forcefully stop instance > > > > So even if we just abstract these checks separately, we have a nicer > > code. Right now, the StopInstance code is somewhat unclean. > > > > This is the "more work" option though. > > > > Should we do it, then, after 2.1.2, perhaps? (since 2.1.2 is already a > bit later than we wanted to)
Yeah. You know what? Please add a try: … except HypevisorError: log.warning() in this patch, and then LGTM. It's the cheapest way to solve this. iustin -- Subscription settings: http://groups.google.com/group/ganeti-devel/subscribe?hl=en
