On Mon, May 10, 2010 at 05:30:28PM +0200, Michael Hanselmann wrote:
> If the version changes, the API is likely to change as well. Not
> having to ask for the version first makes the code simpler.
> 
> Signed-off-by: Michael Hanselmann <han...@google.com>
> ---
>  lib/rapi/client.py |   89 ++++++++++++++++++++++-----------------------------
>  1 files changed, 38 insertions(+), 51 deletions(-)

The patch concept is OK, but the implementation is not.

Please don't hardcode "/2/", use a separate RAPI_VERSION = "2" and then
use that in the URLs.

iustin

Reply via email to