2010/5/11 Iustin Pop <ius...@google.com>: > On Mon, May 10, 2010 at 05:30:37PM +0200, Michael Hanselmann wrote: >> --- a/lib/rapi/client.py >> +++ b/lib/rapi/client.py >> @@ -761,6 +761,21 @@ class GanetiRapiClient(object): >> """ >> return self._SendRequest(HTTP_GET, "/2/jobs/%d" % job_id, None, None) >> >> + def WaitForJobChange(self, job_id, fields, prev_job_info, >> prev_log_serial): >> + return self._SendRequest(HTTP_GET, "/2/jobs/%s/wait" % job_id, None, >> body) > > How will this actually behave? Timeouts, etc.?
The RAPI client doesn't have any timeouts at this point. That's to be done. The RAPI server has a WaitForJobChange timeout of 10 seconds (rlib2._WFJC_TIMEOUT). Otherwise it behaves exactly the same as LUXI's WaitForJobChange, with one exception: If a job isn't found, the server sends an HTTP 404 error. And thinking of this, I just remembered that I forgot something. I'll have another look and then send interdiffs. Michael
