Am 28. Mai 2010 18:16 schrieb Guido Trotter <[email protected]>: > On 28 May 2010 15:29, "Michael Hanselmann" <[email protected]> wrote: >>> LGTM (although as for 3/3 I'm not sure whether this should go to >>> __init__.py or its own socat.py inside impexpd/ >> >> I have additional patches in the pipeline to add code not specific to >> socat. > > that's ok, you can add those to impexpd/somethingelse.py then.
No, the changes go into CommandBuilder and ChildIOProcessor, the main classes in impexp/__init__.py. They can't be separated without much more code. Michael
