On 28 May 2010 17:30, "Michael Hanselmann" <[email protected]> wrote: > Am 28. Mai 2010 18:16 schrieb Guido Trotter <[email protected]>: >> On 28 May 2010 15:29, "Michael Hanselmann" <[email protected]> wrote: >>>> LGTM (although as for 3/3 I'm not sure whether this should go to >>>> __init__.py or its own socat.py inside impexpd/ >>> >>> I have additional patches in the pipeline to add code not specific to >>> socat. >> >> that's ok, you can add those to impexpd/somethingelse.py then. > > No, the changes go into CommandBuilder and ChildIOProcessor, the main > classes in impexp/__init__.py. They can't be separated without much > more code. >
Ok, commandbuilder.py and childioprocessor.py? I'm just thinking that __init__ should be kept for just very small module global functions or empty, for module initialization, rather than putting lots of code there. And if you don't plan to have subfiles, then perhaps impexpd.py rather than impexpd/* ? Thanks, Guido
