On Fri, Jun 10, 2011 at 02:12:09PM +0200, Michael Hanselmann wrote: > Am 10. Juni 2011 14:04 schrieb René Nussbaumer <[email protected]>: > > --- /dev/null > > +++ b/lib/cache.py > > +_cache = None > > +_cache_lock = threading.Lock() > > Why a singleton? Can't you just keep the instance in GanetiContext? > > > + > > +TIMESTAMP = "timestamp" > > +TTL = "ttl" > > +VALUE = "value" > > Please make these private (“_…”).
Not really needed IMHO since they are not re-exported? (the underscore only makes the name longer) iustin
