Am 10. Juni 2011 14:04 schrieb René Nussbaumer <[email protected]>:
> +  def _ExtractValue(self, key):
> +    if key in self.cache:
> +      cache_val = self.cache[key]

Here you look it up twice, too. Since “None” is a valid value (it is,
right?), you have two options to save second lookup:

a)
  _NOTFOUND = object()
  value = self.cache.get(key, _NOTFOUND)
  if value is _NOTFOUND:
    return …
  # use value

b) try:
     value = self.cache[key]
   except KeyError:
     return …
   else:
     # use value

Michael

Reply via email to