LGTM
Thanks,
Guido
On Mon, Nov 26, 2012 at 11:30 AM, Michael Hanselmann <han...@google.com> wrote:
> All resources are acquired and opportunistic instance creations would
> fail. Also add a TODO.
> ---
> lib/cmdlib.py | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/lib/cmdlib.py b/lib/cmdlib.py
> index 6fcb186..656ff0d 100644
> --- a/lib/cmdlib.py
> +++ b/lib/cmdlib.py
> @@ -4057,16 +4057,15 @@ class LUClusterSetParams(LogicalUnit):
> def ExpandNames(self):
> # FIXME: in the future maybe other cluster params won't require checking
> on
> # all nodes to be modified.
> + # FIXME: This opcode changes cluster-wide settings. Is acquiring all
> + # resource locks the right thing, shouldn't it be the BGL instead?
> self.needed_locks = {
> locking.LEVEL_NODE: locking.ALL_SET,
> locking.LEVEL_INSTANCE: locking.ALL_SET,
> locking.LEVEL_NODEGROUP: locking.ALL_SET,
> + locking.LEVEL_NODE_ALLOC: locking.ALL_SET,
> }
> - self.share_locks = {
> - locking.LEVEL_NODE: 1,
> - locking.LEVEL_INSTANCE: 1,
> - locking.LEVEL_NODEGROUP: 1,
> - }
> + self.share_locks = _ShareAll()
>
> def BuildHooksEnv(self):
> """Build hooks env.
> --
> 1.7.7.3
>
--
Guido Trotter
SRE - Corp Computing Services (aka Horsepower)
Google Germany
