LGTM, thanks
On Thu, Nov 29, 2012 at 11:40 AM, Michael Hanselmann <han...@google.com>wrote: > 2012/11/26 Michael Hanselmann <han...@google.com>: > > If the lock was acquired in the first place (only when an iallocator is > > used), it is released as soon as possible. > > Small interdiff: > > --- a/lib/cmdlib.py > +++ b/lib/cmdlib.py > @@ -11020,7 +11020,7 @@ class LUInstanceReplaceDisks(LogicalUnit): > for group_uuid in self.owned_locks(locking.LEVEL_NODEGROUP) > for node_name in self.cfg.GetNodeGroup(group_uuid).members] > else: > - assert not self.lu.glm.is_owned(locking.LEVEL_NODE_ALLOC) > + assert not self.glm.is_owned(locking.LEVEL_NODE_ALLOC) > > self._LockInstancesNodes() > > @@ -11322,6 +11322,7 @@ class TLReplaceDisks(Tasklet): > (owned_nodes, self.node_secondary_ip.keys())) > assert (self.lu.owned_locks(locking.LEVEL_NODE) == > self.lu.owned_locks(locking.LEVEL_NODE_RES)) > + assert not self.lu.glm.is_owned(locking.LEVEL_NODE_ALLOC) > > owned_instances = self.lu.owned_locks(locking.LEVEL_INSTANCE) > assert list(owned_instances) == [self.instance_name], \ > > Michael >
