On Thu, Jan 17, 2013 at 3:44 PM, Constantinos Venetsanopoulos <c...@grnet.gr> wrote: > Hi Guido, > > > On 01/17/2013 04:36 PM, Guido Trotter wrote: > > Wouldn't it be better to just change the nl variable, rather than adding the > primary twice? What do other LUs with hooks on master,pnode and snodes do? > > > I also thought about that, but there is no pretty way to do it, > because you would have to split the above line. I checked other > LUs, but each one does it differently. >
That's ok to split the line above. What's I am saying is that it's better to say nl = ...... (on as many lines as you want) return (nl, nl) Than nl = ....... return (nl + bla, nl + bla) as you repeat the same operation (+ bla) twice for no particular reason. Thanks, Guido
