Yes, LGTM Thanks,
Guido On Fri, Jan 18, 2013 at 10:28 AM, Constantinos Venetsanopoulos <c...@grnet.gr> wrote: > Hello Guido, > > Is that OK with you? > > Thanks, > Constantinos > > > On 01/17/2013 05:49 PM, Constantinos Venetsanopoulos wrote: >> >> Signed-off-by: Constantinos Venetsanopoulos <c...@grnet.gr> >> --- >> lib/cmdlib.py | 5 +++-- >> 1 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/lib/cmdlib.py b/lib/cmdlib.py >> index d97795c..cf4d902 100644 >> --- a/lib/cmdlib.py >> +++ b/lib/cmdlib.py >> @@ -8306,8 +8306,9 @@ class LUInstanceMigrate(LogicalUnit): >> """ >> instance = self._migrater.instance >> - nl = [self.cfg.GetMasterNode()] + list(instance.secondary_nodes) >> - return (nl, nl + [instance.primary_node]) >> + snodes = list(instance.secondary_nodes) >> + nl = [self.cfg.GetMasterNode(), instance.primary_node] + snodes >> + return (nl, nl) >> class LUInstanceMove(LogicalUnit): > > -- Guido Trotter Ganeti engineering Google Germany
