+1 for consistency.

On Mon, Mar 11, 2013 at 10:16 AM, Iustin Pop <[email protected]> wrote:

> Hi all,
>
> The network fields in queries are declared as follows:
>
> - name: QFT_TEXT
> - network: QFT_TEXT
> - gateway: QFT_OTHER
> - network6: QFT_OTHER
> - gateway6: QFT_OTHER
> - mac_prefix: QFT_OTHER
>
> I find this a bit inconsistent; both network, gateway, n6, g6 are IP
> addresses, so we should choose either QFT_TEXT or QFT_OTHER for all of
> them, but not mixed.
>
> MAC prefix is, well, a mac prefix, so it should have the same type as
> above.
>
> Thoughts?
>
> thanks,
> iustin
>

Reply via email to