On 16 May 2013 10:23, Thomas Thrainer <[email protected]> wrote:
> All remaining classes in __init__.py are extracted to misc.py.
>
> Signed-off-by: Thomas Thrainer <[email protected]>
> ---
>  Makefile.am            |   1 +
>  lib/cmdlib/__init__.py | 399 +---------------------------------------------
>  lib/cmdlib/misc.py     | 421 
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  lib/cmdlib/query.py    |   2 +-
>  4 files changed, 425 insertions(+), 398 deletions(-)
>  create mode 100644 lib/cmdlib/misc.py
>
> diff --git a/Makefile.am b/Makefile.am
> index 9a36e4d..1f16894 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -321,6 +321,7 @@ cmdlib_PYTHON = \
>         lib/cmdlib/operating_system.py \
>         lib/cmdlib/tags.py \
>         lib/cmdlib/network.py \
> +       lib/cmdlib/misc.py \
>         lib/cmdlib/test.py

Please sort it.


> diff --git a/lib/cmdlib/misc.py b/lib/cmdlib/misc.py
> +
> +"""Miscellaneous Logical units which don't fit to any category."""

s/Logical/logical/ (maybe s/which/that/) and s/fit to/fit into/

Rest LGTM, thanks.
Bernardo

Reply via email to