On Thu, May 16, 2013 at 7:27 PM, Bernardo Dal Seno <[email protected]>wrote:
> On 16 May 2013 10:23, Thomas Thrainer <[email protected]> wrote: > > All remaining classes in __init__.py are extracted to misc.py. > > > > Signed-off-by: Thomas Thrainer <[email protected]> > > --- > > Makefile.am | 1 + > > lib/cmdlib/__init__.py | 399 > +--------------------------------------------- > > lib/cmdlib/misc.py | 421 > +++++++++++++++++++++++++++++++++++++++++++++++++ > > lib/cmdlib/query.py | 2 +- > > 4 files changed, 425 insertions(+), 398 deletions(-) > > create mode 100644 lib/cmdlib/misc.py > > > > diff --git a/Makefile.am b/Makefile.am > > index 9a36e4d..1f16894 100644 > > --- a/Makefile.am > > +++ b/Makefile.am > > @@ -321,6 +321,7 @@ cmdlib_PYTHON = \ > > lib/cmdlib/operating_system.py \ > > lib/cmdlib/tags.py \ > > lib/cmdlib/network.py \ > > + lib/cmdlib/misc.py \ > > lib/cmdlib/test.py > > Please sort it. > > > > diff --git a/lib/cmdlib/misc.py b/lib/cmdlib/misc.py > > + > > +"""Miscellaneous Logical units which don't fit to any category.""" > > s/Logical/logical/ (maybe s/which/that/) and s/fit to/fit into/ > > Interdiff: diff --git a/lib/cmdlib/misc.py b/lib/cmdlib/misc.py index 78d8f43..12a950b 100644 --- a/lib/cmdlib/misc.py +++ b/lib/cmdlib/misc.py @@ -19,7 +19,7 @@ # 02110-1301, USA. -"""Miscellaneous Logical units which don't fit to any category.""" +"""Miscellaneous logical units that don't fit into any category.""" import logging import time > Rest LGTM, thanks. > Bernardo > -- Thomas Thrainer | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Katherine Stephens
