On 17 May 2013 08:48, Thomas Thrainer <[email protected]> wrote: > > > > On Thu, May 16, 2013 at 5:22 PM, Bernardo Dal Seno <[email protected]> > wrote: >> >> On 16 May 2013 10:23, Thomas Thrainer <[email protected]> wrote: >> > All LUNode* classes are extracted to node.py. Common functions are moved >> > to common.py if used by non-node logical units as well. >> > >> > Signed-off-by: Thomas Thrainer <[email protected]> >> > --- >> > Makefile.am | 1 + >> > lib/cmdlib/__init__.py | 1672 >> > +------------------------------------ >> > lib/cmdlib/common.py | 139 +++ >> > lib/cmdlib/node.py | 1569 >> > ++++++++++++++++++++++++++++++++++ >> > test/py/ganeti.cmdlib_unittest.py | 2 +- >> > 5 files changed, 1720 insertions(+), 1663 deletions(-) >> > create mode 100644 lib/cmdlib/node.py >> >> LGTM except for the fact that the private functions in node.py should >> precede the classes. >> > The reordering incorrectly ended up in the following patch. I moved those > parts from the next patch to this one, the next does no longer touch > node.py. > > Sorry for that.
LGTM, thanks. Bernardo
