On Wed, Jul 10, 2013 at 10:37 AM, Jose A. Lopes <[email protected]>wrote:
> By the way, shouldn't the rule hs-tests-% also delete the file htest.tix ? > Just like the rule hs-tests does ? > I don't think it's really fundamental, but yes, for a better cleanup you can add it. > And I guess I should also add the order dependency $(BUILT_PYTHON_SOURCES). > Don't you think ? > For this, it's really not clear to me why it's there. I actually think it's completely useless and just a remainder of old times. The files that are part of BUILT_PYTHON_SOURCES are already dependencies of test/hs/htest through the rule for building src/Ganeti/Constants.hs. I think it can be removed from the rule from hs-tests as well. Also, I just noticed that the line starting with hs-shell-%: is 81 characters long. This would make a check fail. Please, shorten it. This check is run as part of make commit-check, so you can actually test for it. Cheers, Michele
