On Wed, Jul 10, 2013 at 11:10 AM, Klaus Aehlig <[email protected]> wrote:
> > > And I guess I should also add the order dependency > $(BUILT_PYTHON_SOURCES). > > > Don't you think ? > > > > > > > For this, it's really not clear to me why it's there. I actually think > it's > > completely useless and just a remainder of old times. The files that are > > part of BUILT_PYTHON_SOURCES are already dependencies of test/hs/htest > > through the rule for building src/Ganeti/Constants.hs. I think it can be > > removed from the rule from hs-tests as well. > > Are you saying we should not mention a dependency needed in the rule > just because it's an indirect dependency anyway? What if at some point > we change the dependencies of the build rules that pulls the needed > indirect dependency in? > Of course not. It's just that I cannot see where this dependency is needed by this rule directly. If it is, of course it should be stated, but as far as I can see, we need the python constants (part of the BUILT_PYTHON_SOURCES) just to build the haskell constants that are needed to build test/hs/htest. If this is a case, it shouldn't be a direct dependency of hs-tests-%. On the other hand, if the dependency is there for some other reason... please, enlighten me, because I can't see why! :-) Thanks, Michele
