On Mon, Aug 19, 2013 at 9:13 AM, Thomas Thrainer <[email protected]> wrote: > Hi, > > +1 for splitting big files ;-). And maybe we could lower the maximum line > count even more after this split (it was set after the cmdlib split to > pretty much the size of the biggest file, which probably was backend.py). > > For the split, maybe it makes sense to take a look at rpc_defs.py. > backend.py essentially only implements all the RPC calls (after they went > through noded.py), and the RPC calls are already grouped somehow in > rpc_defs.py. I propose to either split according to the groups in > rpc_defs.py or to regroup the RPC calls there as well. > > Please also note that splitting the file might incur quite some work: First > you would have to find the appropriate branch to do it (in order to ease > merging afterwards, probably 2.8 or 2.9 are fine), then you have to perform > the split (including make files etc.) and finally you probably want to split > tests as well, so that's cleaned up too. As always, reviews have to be done > and the whole work merged up to master afterwards... So I don't know how > well that aligns with your GSoC project (as a quickfix, you can always > disable the warning for backend.py and file a bug about splitting it). >
At this point I would say 2.9. While merging for 2.8 might be painful, we don't expect anything but bugfixes there, as it reached rc status. Thanks, Guido
