> > +extraLogreasonAccess :: String > > +extraLogreasonAccess = Runtime.daemonsExtraLogbase GanetiMond AccessLog > > + > > +extraLogreasonError :: String > > +extraLogreasonError = Runtime.daemonsExtraLogbase GanetiMond ErrorLog > > + > > > > Extreme nitpicking: Logreason is usually in camelcase in most other parts > of the sourcecode, so why not calling these two functions > "extraLogReasonAccess" and "extraLogReasonError"?
Please do nitpick :) Because these are the constants and their names are important to correctly generate the Python name. For example, extraLogreasonAccess -> EXTRA_LOGREASON_ACCESS (Python correct) extraLogReasonAccess -> EXTRA_LOG_REASON_ACCESS > > -daemonsExtraLogbase _ _ = Nothing > > +daemonsExtraLogbase :: GanetiDaemon -> ExtraLogReason -> String > > +daemonsExtraLogbase daemon AccessLog = daemonLogBase daemon ++ "access" > > +daemonsExtraLogbase daemon ErrorLog = daemonLogBase daemon ++ "error" > > > > > The two strings should be "-access" and "-error", to stay compatible with > their current definition in the python constants. Will fix. Thanks, Jose
