On Wed, Sep 18, 2013 at 10:20 AM, Jose A. Lopes <[email protected]>wrote:

> Interdiff
>
> > > -daemonsExtraLogbase _ _ = Nothing
> > > +daemonsExtraLogbase :: GanetiDaemon -> ExtraLogReason -> String
> > > +daemonsExtraLogbase daemon AccessLog = daemonLogBase daemon ++
> "access"
> > > +daemonsExtraLogbase daemon ErrorLog = daemonLogBase daemon ++ "error"
> > >
> > >
> > The two strings should be "-access" and "-error", to stay compatible with
> > their current definition in the python constants.
>
> @@ -125,14 +126,9 @@ daemonGroup (ExtraGroup  AdminGroup)    =
> AutoConf.adminGroup
>
>  data ExtraLogReason = AccessLog | ErrorLog
>
> -daemonsExtraLogbase :: GanetiDaemon -> ExtraLogReason -> Maybe String
> -daemonsExtraLogbase GanetiMond AccessLog =
> -  Just C.daemonsExtraLogbaseGanetiMondAccess
> -
> -daemonsExtraLogbase GanetiMond ErrorLog =
> -  Just C.daemonsExtraLogbaseGanetiMondError
> -
> -daemonsExtraLogbase _ _ = Nothing
> +daemonsExtraLogbase :: GanetiDaemon -> ExtraLogReason -> String
> +daemonsExtraLogbase daemon AccessLog = daemonLogBase daemon ++ "-access"
> +daemonsExtraLogbase daemon ErrorLog = daemonLogBase daemon ++ "-error"
>
> Thanks,
> Jose
>


LGTM, thanks.

Michele

-- 
Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to