Updates:
Status: Fixed
Comment #12 on issue 584 by [email protected]: gnt-backup import fails
with 'VLAN is given, but network mode is not openvswitch'
http://code.google.com/p/ganeti/issues/detail?id=584
Fixed with the following commits:
commit 07e6884884f7a06827173786708c7e3fc924ee62
Author: Thomas Thrainer <[email protected]>
Date: Wed Nov 6 10:36:37 2013 +0100
Don't allow optional node parameters
Ganeti does not support optional fields in parameters
(hypervisor-params, disk-params, etc.). OpenVSwitch related node
parameters were the exception to this rule, which caused numerous
problems related to import/export and (de-)serialization.
The reason for making those parameters optional in the first place was
to
disallow them when OpenVSwitch is not used. This was not consistent with
other parts of Ganeti, where we allow parameters to be set even though
they
are not actively used.
This patch makes all node parameters mandatory and provides sensible
defaults for them. Checks which make sure that certain parameters are
not set in some cases were removed, and the tests adapted. Also, the
inheritance logic from cluster -> node group -> node was implemented, as
it was missing previously.
Signed-off-by: Thomas Thrainer <[email protected]>
Reviewed-by: Hrvoje Ribicic <[email protected]>
commit 818e28cf21f6e08b46654c5d662606ccd020ef4d
Author: Thomas Thrainer <[email protected]>
Date: Wed Nov 6 10:20:59 2013 +0100
Move OVS node parameters to the right place
OpenVSwitch node parameters were passed as separate command line flags.
This was not only inconsistent with all other parameters
(hypervisor-params, disk-params, ...), but also with the documented
behavior in the man pages.
Additionally, the special handling of the OVS related parameters
disabled logic in LUNodeAdd, as ndparams was never None any more.
This patch fixes those problems and treats OVS related parameters like
all other node parameters.
Signed-off-by: Thomas Thrainer <[email protected]>
Reviewed-by: Hrvoje Ribicic <[email protected]>
commit 9a03cffb15cb91564f210c869aad2eea069c9001
Author: Thomas Thrainer <[email protected]>
Date: Wed Nov 6 10:12:06 2013 +0100
Make NIC VLAN queryable
Add an additional query field which makes it possible to query for
VLANs of instance NICs.
Signed-off-by: Thomas Thrainer <[email protected]>
Reviewed-by: Hrvoje Ribicic <[email protected]>
commit 6d9e3ec5597234ddbb7715b1f518ff2cb0f7ae8f
Author: Thomas Thrainer <[email protected]>
Date: Wed Nov 6 10:09:07 2013 +0100
Pass VLAN parameter correctly in moves
Fix the assignment of a wrong value to the VLAN and name parameters of
NICs during instance moves.
Signed-off-by: Thomas Thrainer <[email protected]>
Reviewed-by: Hrvoje Ribicic <[email protected]>
commit dfc3afd96e35b2e759a22e80e846e50ea6dc0117
Author: Thomas Thrainer <[email protected]>
Date: Wed Nov 6 10:07:17 2013 +0100
Use constant instead of raw string
Use the appropriate constant instead of a raw string.
Signed-off-by: Thomas Thrainer <[email protected]>
Reviewed-by: Hrvoje Ribicic <[email protected]>
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
