Hi!

On Mon, Jul 21, 2014 at 5:20 PM, Klaus Aehlig <aeh...@google.com> wrote:

> > diff --git a/lib/client/gnt_node.py b/lib/client/gnt_node.py
> > index 9dfef8b..82f05a6 100644
> > --- a/lib/client/gnt_node.py
> > +++ b/lib/client/gnt_node.py
> > @@ -182,7 +182,7 @@ def _ReadSshKeys(keyfiles, _tostderr_fn=ToStderr):
> >    return result
> >
> >
> > -def _SetupSSH(options, cluster_name, node, ssh_port):
> > +def _SetupSSH(options, cluster_name, node, ssh_port, cl):
> >    """Configures a destination node's SSH daemon.
> >
> >    @param options: Command line options
> > @@ -192,8 +192,21 @@ def _SetupSSH(options, cluster_name, node,
> ssh_port):
> >    @param node: Destination node name
> >    @type ssh_port: int
> >    @param ssh_port: Destination node ssh port
> > +  @type authorized_keys: map of str to str
> > +  @param authorized_keys: a list of keys to be added to the nodes'
> > +    authorized_keys file
>
> That looks spurious. You add one parameter to the signature but you
> add two parameters to the description.
>

Rebase mishap, will fix that and resend the affected patches.


>
>
> > +  @param cl: luxi client
> >
> >    """
>

Cheers,
Helga



>
> --
> Klaus Aehlig
> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
>



-- 
Helga Velroyen | Software Engineer | hel...@google.com |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to