Hi!

On Tue, Jul 22, 2014 at 6:51 PM, Klaus Aehlig <aeh...@google.com> wrote:

> > +  key_values = []
> > +  for keys in authorized_keys.values():
> > +    key_values += keys
>
> How is that different from a copy of authorized_keys.values() ?
> Not that in the rest neither is modified, so why would
>
> keys_values = authorized_keys.values()
>
> not work?
>
>
Good point, thanks. I refactored this method like 100 times and it seems I
did not do the final simplification step. Will resend patch.

Cheers,
Helga

P. S. It is easier to find the file to edit this if you keep the rest of
the quote. :)


> --
> Klaus Aehlig
> Google Germany GmbH, Dienerstr. 12, 80331 Muenchen
> Registergericht und -nummer: Hamburg, HRB 86891
> Sitz der Gesellschaft: Hamburg
> Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
>



-- 
Helga Velroyen | Software Engineer | hel...@google.com |

Google Germany GmbH
Dienerstr. 12
80331 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Christine Elizabeth Flores

Reply via email to