This patch series looks good to me. However, I am wondering if it would be a good thing for the user to explicity override the test for cases where the version number differs but the user is sure that the migration will work. Something like --force etc. Otherwise we severly limit migratability, even if in the future cross-hypervisor-version-migrations might be come more easily possible.
What do you think? On Tue, Oct 7, 2014 at 11:04 AM, 'Klaus Aehlig' via ganeti-devel < [email protected]> wrote: > > While for Xen it is a necessary safty feature to prevent > migration between incompatible versions. For kvm, it is > a bit more complicated; already in stable-2.8, the > machine_version feature was added to the kvm hypervisor. > So restore the old (unchecked) behavior for kvm in order > to avoid regressions when so far valid use cases would start > to fail. To achieve this, make the version-compatibility > check hypervisor specific. > > Klaus Aehlig (4): > Extend the Hypervisor interface by VersionsSafeForMigration > Use HV-specific version comparison function > Move Xen-specific version test hv_xen > Be optimistic for kvm migration > > lib/cmdlib/instance_migration.py | 4 +++- > lib/hypervisor/hv_base.py | 13 +++++++++++++ > lib/hypervisor/hv_kvm/__init__.py | 10 ++++++++++ > lib/hypervisor/hv_xen.py | 21 +++++++++++++++++++++ > lib/utils/version.py | 21 --------------------- > test/py/ganeti.hypervisor.hv_xen_unittest.py | 12 ++++++++++++ > test/py/ganeti.utils.version_unittest.py | 18 ------------------ > 7 files changed, 59 insertions(+), 40 deletions(-) > > -- > 2.1.0.rc2.206.gedb03e5 > > -- Helga Velroyen | Software Engineer | [email protected] | Google Germany GmbH Dienerstr. 12 80331 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores
