On Thu, Jun 25, 2015 at 05:32:18PM +0200, 'Helga Velroyen' via ganeti-devel wrote: > This is a small patch cleaning up some thing in the > composition of the pycurl object for RPC calls. > For example, it removes some superfluous 'str' and > increases the logging level to warning when the > server cert is used. > > Signed-off-by: Helga Velroyen <[email protected]> > --- > lib/rpc/node.py | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-)
> curl.setopt(pycurl.FOLLOWLOCATION, False) > - curl.setopt(pycurl.CAINFO, noded_cert) > curl.setopt(pycurl.SSL_VERIFYHOST, 0) > curl.setopt(pycurl.SSL_VERIFYPEER, True) > curl.setopt(pycurl.SSLCERTTYPE, "PEM") > curl.setopt(pycurl.SSLCERT, noded_client_cert) > curl.setopt(pycurl.SSLKEYTYPE, "PEM") > curl.setopt(pycurl.SSLKEY, noded_client_cert) > + curl.setopt(pycurl.CAINFO, noded_cert) > curl.setopt(pycurl.CONNECTTIMEOUT, constants.RPC_CONNECT_TIMEOUT) Do curl options not commute? If so, please comment on why. Otherwise, what tis the reason to move that line unchanged to a different place? -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
