> > > - if utils.version.IsBefore(version, 2, 11, 0): > > > + if utils.version.IsBefore(version, 2, 12, 0): > > > > Should this be really 2, 12, 0 or even 2, 12, 5? As far > > as I can see 2.12.4 also has only self-signed certificates. > > I'm thinking about upgrades from 2.12.4 to 2.12.5 using > > 'gnt-cluster upgrade --to 2.12.5' which is possible if > > Ganeti is configured with --enable-versionfull. > > > > Hm, sounds okay to me, but what would happen if we pin it down to 2.12.5 > and people upgrade to 2.12 which have not '--enable-versionfull' enabled? > Will that still have the desired effect? (I assume so, but would like you > to confirm.)
Yes, changing "if utils.version.IsBefore(version, 2, 12, 0)" to "if utils.version.IsBefore(version, 2, 12, 5)" will only result in the action being run more often (a version that is before 2.12.0 is always also before 2.12.5). [BTW, once this gets merged to 2.14, it has to be updated there again: upgrades from 2.13.[01] to 2.14.1 also need to run renew-crypto. We should keep this in mind when merging that series up. ] -- Klaus Aehlig Google Germany GmbH, Dienerstr. 12, 80331 Muenchen Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschaeftsfuehrer: Graham Law, Christine Elizabeth Flores
