--- Caleb Epstein <[EMAIL PROTECTED]> wrote: > On 10/26/06, Caleb Epstein <[EMAIL PROTECTED]> wrote: > > So val.f will be zero when bytes_in < last_bytes_in. Since these > > counters are known to be 32-bit unsigned integers, can't this code > do > > a better job of calculating diff? Something like: > > OK, see attached patch against 3.0.3. This seems to fix this > overflow > problem here, and it eliminates a *lot* of redundant code from the > Linux version of metrics.c. > > -- > Caleb Epstein Hi Caleb,
your patch does no longer apply to the 3.0.4 source. Would it be possible for you to rebase the patch against 3.0.4 or current SVN? I definitely like the code/complexity reduction. We should do the same for the cpu_*_func family. Sorry for the inconvenience. Cheers Martin ------------------------------------------------------ Martin Knoblauch email: k n o b i AT knobisoft DOT de www: http://www.knobisoft.de
