Hi all:

On Tue, Jun 17, 2008 at 12:24 PM, Jarod Wilson <[EMAIL PROTECTED]> wrote:

>> I'd agree that this one isn't a huge deal. Things end up where they're
>> supposed to, its just not done quite correctly yet. Haven't dug into what
>> needs fixing, but basically, if a libdir value is passed in, it shouldn't
>> be overridden. Its the correct default, just need to respect values people
>> pass in via configure.
>
> Also, for the record, Fedora's ganglia maintenance is in the process of being
> handed off to Kostas Georgiou, who I'm adding to the cc here to keep him
> apprised of the situation.

Currently it looks like $libdir gets overwritten by the hardcoded
values in configure.in.  The following patch (against trunk) is
supposed to fix that:

Index: configure.in
===================================================================
--- configure.in        (revision 1422)
+++ configure.in        (working copy)
@@ -580,12 +580,12 @@
   prefix="$ac_default_prefix"
 fi

-if test "x$host_cpu" = "xx86_64"; then
-  libdir="$prefix/lib64"
-else
-  libdir="$prefix/lib"
+if test "x$exec_prefix" = "xNONE"; then
+  exec_prefix="$prefix"
 fi

+libdir=`eval echo $libdir`
+
 AC_OUTPUT(Makefile
           ganglia-config
           tests/Makefile

Supposedly on x86_64 archs (and presumably powerpc as well), libdir
will expand correctly to $exec_prefix/lib64, however I can't test this
out.  At any rate, if that does not work, passing --libdir to
./configure does work as expected now.

At any rate, I have tested the following cases and they all behave as
expected on x86:

1) ./configure (/usr/lib)
2) ./configure --prefix=/opt/ganglia (/opt/ganglia/lib)
3) ./configure --exec_prefix=/opt (/opt/lib)
4) ./configure --libdir=/usr/lib64 (/usr/lib64)

If I can get confirmation that this is fine, I'll check this into
trunk and submit a backport proposal for 3.1.x.  After this is checked
in I will tag/create RC1 tarball.  I am thinking the frontend fixes
could wait until RC2 as it is not trivial to get everything to the way
I wanted, so I need to spend a little more time on it.

Cheers,

Bernard

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers

Reply via email to