+1; we patched like that, too, and monitor the same way.
-- ReC
On Sep 11, 2009, at 6:43 AM, Spike Spiegel wrote:
> Hi,
>
> recently we added better monitoring for our ganglia infrastructure and
> one of the checks for gmetad contacts it on port 8651, looks for some
> XML string and exits (receiving 20+ MBs of xml every time we run the
> check isn't an option). The 'exists' part means sending a RST before
> gmetad has sent all data which causes root_report_end() to fail with
> subsequent message 'server_thread() %d unable to write root epilog'
> being logged. Is it really necessary to log an error message if the
> client goes away early? after all it's not ganglia/gmetad
> malfunctioning or anything, and we could still keep that for debug
> mode. If that makes sense to you the one line patch is below.
>
> thanks
>
> Index: server.c
> ===================================================================
> --- server.c (revision 2058)
> +++ server.c (working copy)
> @@ -639,7 +639,7 @@
>
> if(root_report_end(&client))
> {
> - err_msg("server_thread() %d unable to write root
> epilog", pthread_self() );
> + debug_msg("server_thread() %d unable to write root
> epilog", pthread_self() );
> }
>
> close(client.fd);
>
> --
> "Behind every great man there's a great backpack" - B.
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008
> 30-Day
> trial. Simplify your report design, integration and deployment - and
> focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now. http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Ganglia-developers mailing list
> Ganglia-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ganglia-developers
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ganglia-developers mailing list
Ganglia-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ganglia-developers
