On 06/16/2015 02:45 AM, Richard Sandiford wrote:
As described in the covering note, this patch replaces handle_cache_entry
with a new function keep_cache_entry.  It also ensures that elements are
deleted using the proper function, so that m_n_deleted is updated.

I couldn't tell whether the unusual name of the function
("gt_cleare_cache") is deliberate or not, but I left it be.
Short-hand for clear_entry or something similar?



gcc/ada/
        * gcc-interface/decl.c (value_annotation_hasher::handle_cache_entry):
        Delete.
        (value_annotation_hasher::keep_cache_entry): New function.
        * gcc-interface/utils.c (pad_type_hasher::handle_cache_entry):
        Delete.
        (pad_type_hasher::keep_cache_entry): New function.

gcc/
        * hash-table.h (hash_table): Add gt_cleare_cache as a friend.
        (gt_cleare_cache): Check here for deleted and empty entries.
        Replace handle_cache_entry with a call to keep_cache_entry.
        * hash-traits.h (ggc_cache_hasher::handle_cache_entry): Delete.
        (ggc_cache_hasher::keep_cache_entry): New function.
        * trans-mem.c (tm_wrapper_hasher::handle_cache_entry): Delete.
        (tm_wrapper_hasher::keep_cache_entry): New function.
        * tree.h (tree_decl_map_cache_hasher::handle_cache_entry): Delete.
        (tree_vec_map_cache_hasher::keep_cache_entry): New function.
        * tree.c (type_cache_hasher::handle_cache_entry): Delete.
        (type_cache_hasher::keep_cache_entry): New function.
        (tree_vec_map_cache_hasher::handle_cache_entry): Delete.
        (tree_vec_map_cache_hasher::keep_cache_entry): New function.
        * ubsan.c (tree_type_map_cache_hasher::handle_cache_entry): Delete.
        (tree_type_map_cache_hasher::keep_cache_entry): New function.
        * varasm.c (tm_clone_hasher::handle_cache_entry): Delete.
        (tm_clone_hasher::keep_cache_entry): New function.
        * config/i386/i386.c (dllimport_hasher::handle_cache_entry): Delete.
        (dllimport_hasher::keep_cache_entry): New function.
So for all the keep_cache_entry functions, I guess they're trivial enough that a function comment probably isn't needed. Presumably no good way to share the trivial implementation?

OK for the trunk.

jeff

Reply via email to