On Thu, Mar 03, 2016 at 11:31:08PM -0700, Jeff Law wrote: > Do we need to do anything for the call into c_parser_postfix_expression that > occurs between the two you changed in this patch. > > I think you can get into that code with something like > > _Cilk_spawn _Cilk_spawn (<whatever>));
Absolutely. Dunno how I missed that. Will fix in a new version of the patch... > For the non-error case (the second one you changed), I think we do want to > verify that the expression we got back was a function call and issue an > appropriate error otherwise. You could make an argument that we should > issue a diagnostic for the other cases as well, but it's less obviously > correct. As noted elsewhere, cilk_set_spawn_marker rejects everything except CALL_EXPR. Marek