On Mon, Mar 07, 2016 at 12:57:20PM +0100, Richard Biener wrote:
> > Honza, can you please repost the patch. Richard said on IRC that he may
> > reconsider his rejection after all.
> >
> > I've tested the patch on my Gentoo test machine and it fixes segfaults
> > in LLVM, QT, Chromium, Kdevelop.
> >
> > If the patch gets accepted, changes.html and porting_to.html need to be
> > updated to reflect the new flag.
>
> Note that I'll only re-consider if we want to make this flag enabled by
> default.
By enabled by default you mean what exactly? That by default this will not
be treated as non-NULL anymore? I'm against that, while there are large
codebases that are coded in "C++", there are plenty of properly written
packages and by deferring this optimization we'd just delay the fixing of
firefox etc.
> (no strong opinion about that - but for example the recent -flifetime-dse
> strengthening fallout is similar)
-flifetime-dse change is different, we default to -flifetime-dse=2, but have
a way for broken packages to workaround their bugs, so that situation is the
same as with -fno-delete-null-pointer-checks.
Jakub
