On Mon, Jun 13, 2016 at 04:43:25PM +0200, Thomas Schwinge wrote: > On Wed, 01 Jun 2016 17:06:42 +0200, Thomas Schwinge <tho...@codesourcery.com> > wrote: > > Here are the OpenACC bits of <http://gcc.gnu.org/PR71373>. > > In the PR, Jakub clarified that all the missing other OMP_CLAUSE_* are in > fact all unreachable here. OK to document this as follows, in trunk? > > The "anything else" default case in fact now is just the non-clause > OMP_CLAUSE_ERROR, so when adding a case for that one, we could then > remove the default case, and thus get a compiler warning when new clauses > are added in the future, without handling them here. That makes sense to > me (would have made apparent much earlier the original problem of missing > handling for certain OMP_CLAUSE_*), but based on feedback received, it > feels as if I'm the only supporter of such "defensive" programming > paradigms? > > commit c6b10a9bc1437395c4931d43f30e778152a28cb2 > Author: Thomas Schwinge <tho...@codesourcery.com> > Date: Mon Jun 13 16:29:37 2016 +0200 > > [PR middle-end/71373] Document missing OMP_CLAUSE_* in gcc/tree-nested.c > > gcc/ > * tree-nested.c (convert_nonlocal_omp_clauses): > (convert_local_omp_clauses): Document missing OMP_CLAUSE_*.
Ok, but please mention the PR line above the ChangeLog entry. Thanks. Jakub