On 07/19/2016 12:35 PM, Richard Biener wrote:
I wouldn't mind seeing tree-vrp broken down a little -- it's quite
large and there's at least 4 distinct things going on in that
file.
1. ASSERT_EXPR handling.
2. Arithmetic on ranges
3. Propagation engine setup, callbacks, etc
4. Range management
There may be others, but it seems at least some of that ought to be
factored out.
Possibly, but not necessarily because of the proposed pass.
Right. These are things that, in my mind ought to be done regardless of
the introduction of IPA-VRP.
I'd like to see lattices and lattice entries becoming classes and the
arithmetic on it being templated on it.
Seems reasonable as well.
I do have some preliminary patches implementing a aggressive
on-drmand VRP for the use in niter analysis and the Lattice is what
makes sharing code difficult (it's a hash-map instead of an array
there).
It's interesting you mention an on-demand VRP. I've asked Andrew to
poke that that some too. It's for a different need, but interesting
that we're both looking to take things in that direction.
Jeff
