On 10/14/2016 08:16 PM, David Malcolm wrote:
In this version of the patch, I've moved the global variables to
be fields of class rtx_reader, moving their setup to the constructor.
The patch adds matching cleanups to the destructor, along with a
cleanup of m_base_dir.
Doing so requires updating the various users of these fields.
Where it seemed appropriate, I made the functions be methods
of rtx_reader. In other cases, I updated them to access the fields
Successfully bootstrapped®rtested on x86_64-pc-linux-gnu.
Well, at least the actual patch doesn't look as scary as the ChangeLog.
There are things one could discuss, like maybe gensupport should just
have its own string obstack. But on the whole I think this is
reasonable, so OK.