Hi! Thank you for looking at this. On Fri, Apr 21, 2017 at 02:39:36PM +0200, Gerald Pfeifer wrote: > On Thu, 20 Apr 2017, Segher Boessenkool wrote: > > + <li>There are new options <code>-mstack-protector-guard=global</code>, > > + <code>-mstack-protector-guard=tls</code>, > > + <code>-mstack-protector-guard-reg=</code>, and > > + <code>-mstack-protector-guard-offset=</code>, to change how the stack > > + protector gets the value to use as canary.</li> > > no comma before "to change".
Oxford comma :-) I'll get rid of it, sure. > And perhaps simply "New options...change how..."? Sure, good plan. > The patch is fine if you consider this feedback. > > Well, one question: Don't these options do more than just changing > how the value is obtained? The way I read the documentation the first > two initiate generation of stack protection code? Am I confused, or > should either the web patch or the documentation be adjusted? No, this is correct. The documentation could be clearer yes. I'll try to improve it; help is more than welcome ;-) Segher
